tests: remove redundant comparison in repo dump/restore #18660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a leftover forgotten in go-gitea#18621 Signed-off-by: singuliere <[email protected]>
|
Please could you explain what this was doing and why it is no longer needed. |
GiteaBot
added
the
lgtm/need 2
The description of the pr was updated with links and a detailed explanation. |
zeripath
approved these changes
Feb 9, 2022
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 10, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #18660 +/- ##
==========================================
- Coverage 46.64% 46.45% -0.20%
==========================================
Files 846 851 +5
Lines 121331 121925 +594
==========================================
+ Hits 56595 56637 +42
- Misses 57859 58411 +552
Partials 6877 6877
Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 10, 2022
* giteaofficial/main: Fix issue with docker-rootless shimming script (go-gitea#18690) tests: remove redundant comparison in repo dump/restore (go-gitea#18660) [skip ci] Updated translations via Crowdin Disable unnecessary OpenID/OAuth2 elements (go-gitea#18491) Add apply-patch, basic revert and cherry-pick functionality (go-gitea#17902) C preprocessor colors improvement (go-gitea#18671) Update object repo with the migrated repository (go-gitea#18684)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
It is a leftover forgotten in go-gitea#18621 Signed-off-by: singuliere <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a leftover forgotten in #18621
This code block was replaced by these tests. But it was also incorrectly copy/pasted before them, duplicating the verification.
Duplicating a verification is not, in itself, a bad thing. But the verification is also done in a different, less flexible, way that is more likely to fail in the future, when new fields are added. It would create additional maintenance work and it would be a waste of effort because the tests it provides are now redundant.