Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown rendering overhaul #186

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Markdown rendering overhaul #186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ae1a52
Markdown rendering overhaul
andrew-boyarshin Feb 9, 2017
efb718c
Fix markdown API, add markdown module and API tests, improve code cov…
andrew-boyarshin Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,11 @@ func runWeb(ctx *cli.Context) error {
}, reqSignIn, reqRepoWriter)
}, repo.MustEnableWiki, context.RepoRef())

m.Group("/wiki", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the Markdown rendering?

Copy link
Contributor Author

@andrew-boyarshin andrew-boyarshin Nov 16, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metalmatze Related closely. To support all types of embedding images into markdown files (both in wiki and repo itself) I changed wiki content loading scheme. Without this change markdown files with HTML <img> tags inside would fail to load pictures.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, no problem. Just seemed unrelated to me at first glance.

m.Get("/raw/*", repo.WikiRaw)
m.Get("/*", repo.WikiRaw)
}, repo.MustEnableWiki)

m.Get("/archive/*", repo.Download)

m.Group("/pulls/:index", func() {
Expand Down
Loading