Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Public SSH Key tmp file after calculating fingerprint #1855

Merged
merged 5 commits into from
Jun 8, 2017
Merged

Delete Public SSH Key tmp file after calculating fingerprint #1855

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a1b51e
Delete public key tmp file after calculating fingerprint
dnmgns May 31, 2017
0d0f6e4
Move line
dnmgns Jun 5, 2017
0cecf3e
Remove defer statement
dnmgns Jun 5, 2017
f84bc06
Readd defer statement and move remove
dnmgns Jun 7, 2017
b03b204
Delete space
dnmgns Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions models/ssh_key.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ func calcFingerprint(publicKeyContent string) (string, error) {
} else if len(stdout) < 2 {
return "", errors.New("not enough output for calculating fingerprint: " + stdout)
}
os.Remove(tmpPath)
Copy link
Member

@sapk sapk Jun 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should still use defer before executing ssh-keygen (after checking empty string) since if the check failed the file is not removed otherwise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See SSHKeyGenParsePublicKey on where to place defer remove

return strings.Split(stdout, " ")[1], nil
}

Expand Down