Display draft releases #1854
Merged
Display draft releases #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests are welcome. |
tboerger
added
the
lgtm/need 2
sapk
reviewed
Jun 2, 2017
| } | ||
| r.Note = markdown.RenderString(r.Note, ctx.Repo.RepoLink, ctx.Repo.Repository.ComposeMetas()) | ||
| releasesToDisplay = append(releasesToDisplay, r) |
There was a problem hiding this comment.
This wouldn't be "faster" using the index of the for loop and directly assigning releasesToDisplay[index] ?
There was a problem hiding this comment.
We sometimes continue (line 88)
There was a problem hiding this comment.
ok but we don't exceed len(releases) + if we skip we should not use pager := paginater.New(len(releases), limit, page, 5) but len(releasesToDisplay)
sapk
reviewed
Jun 2, 2017
routers/repo/release.go
Outdated
| @@ -79,7 +79,7 @@ func Releases(ctx *context.Context) { | |||
|
|
|||
| // Temporary cache commits count of used branches to speed up. | |||
| countCache := make(map[string]int64) | |||
| var cacheUsers = make(map[int64]*models.User) | |||
| cacheUsers := map[int64]*models.User{ctx.User.ID: ctx.User} | |||
|
Except my little proposition for optimization and that we need more testing generally. This PR LGTM. |
tboerger
added
lgtm/need 1
|
@lunny Added an integration test |
|
LGTM |
tboerger
added
lgtm/done
appleboy
approved these changes
Jun 3, 2017
This was referenced Jun 3, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1387. Previously, we only displayed releases whose tag name actually existed in the repository, which is why drafts did not show up.