Fix user profile activity feed #1848
Conversation
ethantkoenig
force-pushed
the
fix/activity_feed
branch
from
142d061
to
8b1e87c
Compare
models/action.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("AccessibleReposEnv: %v", err) | ||
| } | ||
| repoIDs, err := env.RepoIDs(1, ctxUser.NumRepos) | ||
| repoIDs, err := env.RepoIDs(1, options.RequestedUser.NumRepos) |
There was a problem hiding this comment.
This will make two DB connection in a goroutine. Maybe sqlite will lock table.
There was a problem hiding this comment.
I don't see a nice way to use the same connection in both places (i.e. the sess variable and this line). If you have a more specific suggestion about how to only make one connection, let me know.
For what it's worth, the first session (i.e. the sess variable) won't actually connect to the database until line 704, so I don't think the two connections will ever overlap.
There was a problem hiding this comment.
Maybe change AccessibleReposEnv to add a new Engine field.
There was a problem hiding this comment.
I've rearranged the code so that these calls take place before sess is even created.
|
Otherwise LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
1 similar comment
|
LGTM |
tboerger
added
lgtm/done
Fixes #1202.
Causes the activity feed on a user's profile page to only be actions performed by that user. The activity feed on the dashboard is unchanged, and still shows relevant actions performed by other users.