Don't ignore error in getMergeCommit #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
LGTM |
tboerger
added
the
lgtm/need 1
appleboy
approved these changes
Jun 1, 2017
|
LGTM |
tboerger
added
lgtm/done
ethantkoenig
added a commit
to ethantkoenig/gitea
that referenced
this pull request
Jul 11, 2017
appleboy
pushed a commit
that referenced
this pull request
Jul 11, 2017
* Fix fast-forward PR bug * Don't ignore error in getMergeCommit (#1843)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for previously-ignored error in
PullRequest.getMergeCommit(), and return appropriate errors in unexpected circumstances.Should help in debugging #1186 (note: this PR does NOT fix the problem, but only helps to diagnose it)