Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error from mktemp command in MacOS. #1837

Merged
merged 2 commits into from
Jun 4, 2017
Merged

fix: error from mktemp command in MacOS. #1837

merged 2 commits into from
Jun 4, 2017

Conversation

appleboy
Copy link
Member

Error: Permission denied from mktemp command in MacOS.

$ make test-vendor
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix
govendor list +unused | tee "/wc-gitea-unused"
tee: /wc-gitea-unused: Permission denied

@appleboy appleboy added the type/enhancement An improvement of existing functionality label May 31, 2017
@appleboy appleboy added this to the 1.2.0 milestone May 31, 2017
sapk
sapk reviewed Jun 3, 2017
View reviewed changes
Makefile Outdated
@@ -22,7 +15,13 @@ SOURCES ?= $(shell find . -name "*.go" -type f)

TAGS ?=

TMPDIR := $(shell mktemp -d)
TMPDIR := $(shell mktemp -d 2>/dev/null || mktemp -d -t 'tempdir')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a "gitea-temp" in place of "tempdir" to be more indicative ?

sapk
sapk reviewed Jun 3, 2017
View reviewed changes
Makefile Outdated
TMPDIR := $(shell mktemp -d)
TMPDIR := $(shell mktemp -d 2>/dev/null || mktemp -d -t 'tempdir')

ifeq ($(OS), Windows_NT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to move this ?

@sapk
Copy link
Member

sapk commented Jun 3, 2017 •
edited
Loading

Few little comments but LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 3, 2017
@ethantkoenig
Copy link
Member

LGTM (aside from @sapk's comments)

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2017
@appleboy
Copy link
Member Author

appleboy commented Jun 4, 2017

@sapk Done. update temp name.

@appleboy appleboy merged commit e7ae13d into go-gitea:master Jun 4, 2017
@appleboy appleboy deleted the tempdir branch June 4, 2017 08:48
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@wetneb @earl-warren
[GITEA] Enable mocked HTTP responses for GitLab migration test
01b0ead 
Fix gitlab migration unit test

Closes go-gitea#1837.

The differences in dates can be explained by commit e19b965, which
changed the order in which "created_date" and "updated_date" are
considered.

(cherry picked from commit b0bba20aa44e30ef0296b89f336d426224d73a16)

Mock HTTP requests in GitLab migration test

This introduces a new utility which can be added to other tests
making HTTP calls to a live service, to cache the responses of this
service in the repository.

(cherry picked from commit 52053b138948bd74c7eb88c0796c2e18f4247f3c)

Enable mocked HTTP responses for GitLab migration test

(cherry picked from commit 19cefc4de24b935a6a5c92be8360301f196f3aa5)

Simplify HTTP mocking utility in unit tests

Follow-up to https://codeberg.org/forgejo/forgejo/pulls/1841

(cherry picked from commit ca517c8bb4bf97f061b8b19fd3303d734f46660c)
(cherry picked from commit b227e0dd6bdf2dc3e8679443fc538fbce4b3bcf5)
(cherry picked from commit 6cc9d06556cda6c952a0542284fbe504114971ce)
(cherry picked from commit f0746e648dc30510d655b8a3b821199b2638800f)
(cherry picked from commit 4141933)
(cherry picked from commit 6e93df3bbb6c589502afc9dc74a7ae1a7c0f7da8)
(cherry picked from commit db0dbab5527c9f1783fd0eddb057c2d91cbb67e4)
(cherry picked from commit 8f9c9c63fbd3f266bb29d38791e83dc369cc1350)

(cherry picked from commit e74e26203095b675ccedbc2e166faed59369d467)
(cherry picked from commit 2e0933edcfa102b578fb3c2500f9e6af9e5ba1c7)
(cherry picked from commit 65060c69616631221d3dd9ef8b48fbcb007ad0c6)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@appleboy @sapk @ethantkoenig @tboerger