(Discontinued) Show error logs in embedded sub-command#18121
Closed
wxiaoguang wants to merge 3 commits intogo-gitea:mainfrom
Closed
(Discontinued) Show error logs in embedded sub-command#18121wxiaoguang wants to merge 3 commits intogo-gitea:mainfrom
wxiaoguang wants to merge 3 commits intogo-gitea:mainfrom
Conversation
lunny
approved these changes
Dec 29, 2021
Merged
Contributor
Author
|
I need think and test more. Give me some more time on this. |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Discontinued, feel free to take it or make a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves:
Before: if Fatal error occurs, users see nothing, Gitea exits.
Now: If Fatal error occurs, users can know what happened.
There are still many flaws in Gitea setting system, some fatal errors during CLI sub-commands can be:
cap_net_bind_servicepermissionThat's very unfriendly to users and stops
embeddedsub-command, the Gitea setting system should be polished more, that's what I mean "partially resolves".