Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change <a> elements to underline on hover #17898

Merged
merged 2 commits into from
Dec 18, 2021
Merged

Change <a> elements to underline on hover #17898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b93b93
Change <a> elements to underline on hover
silverwind Dec 3, 2021
e724d4f
Merge branch 'main' into ahover
lunny Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions templates/shared/issuelist.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,12 @@
</div>
<div class="issue-item-main f1 fc df">
<div class="issue-item-top-row">
<a class="title" href="{{if .HTMLURL}}{{.HTMLURL}}{{else}}{{$.Link}}/{{.Index}}{{end}}">
{{RenderEmoji .Title}}
{{if .IsPull }}
{{if (index $.CommitStatus .PullRequest.ID)}}
{{template "repo/commit_status" (index $.CommitStatus .PullRequest.ID)}}
{{end}}
<a class="title tdn" href="{{if .HTMLURL}}{{.HTMLURL}}{{else}}{{$.Link}}/{{.Index}}{{end}}">{{RenderEmoji .Title}}</a>
{{if .IsPull}}
{{if (index $.CommitStatus .PullRequest.ID)}}
{{template "repo/commit_status" (index $.CommitStatus .PullRequest.ID)}}
{{end}}
</a>
{{end}}
<span class="labels-list ml-2">
{{range .Labels}}
<a class="ui label" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&state={{$.State}}&labels={{.ID}}{{if ne $.listType "milestone"}}&milestone={{$.MilestoneID}}{{end}}&assignee={{$.AssigneeID}}" style="color: {{.ForegroundColor}}; background-color: {{.Color}}" title="{{.Description | RenderEmojiPlain}}">{{.Name | RenderEmoji}}</a>
Expand Down Expand Up @@ -126,14 +124,14 @@
</div>
<div class="issue-item-icon-right text grey">
{{range .Assignees}}
<a class="ui assignee tooltip" href="{{.HomeLink}}" data-content="{{.GetDisplayName}}" data-position="left center">
<a class="ui assignee tooltip tdn" href="{{.HomeLink}}" data-content="{{.GetDisplayName}}" data-position="left center">
{{avatar .}}
</a>
{{end}}
</div>
<div class="issue-item-icon-right text grey">
{{if .NumComments}}
<a href="{{if .HTMLURL}}{{.HTMLURL}}{{else}}{{$.Link}}/{{.Index}}{{end}}">
<a class="tdn" href="{{if .HTMLURL}}{{.HTMLURL}}{{else}}{{$.Link}}/{{.Index}}{{end}}">
{{svg "octicon-comment" 16 "mr-2"}}{{.NumComments}}
</a>
{{end}}
Expand Down
1 change: 1 addition & 0 deletions web_src/fomantic/_site/globals/site.variables
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
@useCustomScrollbars: false;
@disabledOpacity: var(--opacity-disabled);
@variationPopupTooltip: false;
@linkHoverUnderline: underline;
2 changes: 1 addition & 1 deletion web_src/fomantic/build/semantic.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 14 additions & 1 deletion web_src/less/_base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ a,
.ui.breadcrumb a {
color: var(--color-primary);
cursor: pointer;
text-decoration-skip-ink: all;
}

a.muted {
Expand All @@ -245,7 +246,19 @@ a.muted {
a:hover,
a.muted:hover,
.ui.breadcrumb a:hover {
color: var(--color-primary-dark-2);
color: var(--color-primary);
}

a.label,
.repository-menu a,
.ui.search .results a,
.ui .menu a,
.issue-keyword a {
text-decoration: none !important;
}

.ui.breadcrumb a:hover {
text-decoration: underline !important;
}

.ui.breadcrumb .divider {
Expand Down
21 changes: 3 additions & 18 deletions web_src/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2837,20 +2837,6 @@ tbody.commit-list {
}
}

.commit-summary a {
&:hover {
text-decoration: underline solid;
}

&.default-link {
text-decoration: none;

&:hover {
text-decoration: underline solid;
}
}
}

.commit-list .commit-status-link {
display: inline-block;
vertical-align: middle;
Expand Down Expand Up @@ -3012,13 +2998,12 @@ td.blob-excerpt {
background-color: #fafafa;
}

.issue-keyword,
.commit-body .issue-keyword:hover {
border-bottom: 1px dotted var(--color-text-light-2);
.issue-keyword {
border-bottom: 1px dotted var(--color-text-light-3) !important;
}

.issue-keyword:hover {
border-bottom: none;
border-bottom: none !important;
}

.file-header {
Expand Down
1 change: 1 addition & 0 deletions web_src/less/helpers.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
.ac { align-items: center !important; }
.tc { text-align: center !important; }
.tl { text-align: left !important; }
.tdn { text-decoration: none !important; }
zeripath marked this conversation as resolved.
Show resolved Hide resolved
.jc { justify-content: center !important; }
.js { justify-content: flex-start !important; }
.je { justify-content: flex-end !important; }
Expand Down