Skip to content

Check if column exist before rename if exist, just return with no error (#17870) #17882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6543 merged 1 commit into from
Dec 2, 2021
Merged

Check if column exist before rename if exist, just return with no error (#17870) #17882

6543 merged 1 commit into from
Dec 2, 2021

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 2, 2021

backport from #17870

  • Check if column exist before rename if exist, just return with no error

  • Also check if errors column exist

  • Add comment for migration

  • Fix sqlite test

@lunny
Check if column exist before rename if exist, just return with no err…
f24ddc7 
…or (go-gitea#17870)

* Check if column exist before rename if exist, just return with no error

* Also check if errors column exist

* Add comment for migration

* Fix sqlite test
@lunny lunny added the type/bug label Dec 2, 2021
@lunny lunny added this to the 1.15.7 milestone Dec 2, 2021
@lunny lunny mentioned this pull request Dec 2, 2021
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2021
@6543 6543 merged commit 56a3b50 into go-gitea:release/v1.15 Dec 2, 2021
@lunny lunny deleted the lunny/upgrade_avoid_rename_failure2 branch December 3, 2021 01:26
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.15.7

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @zeripath @wxiaoguang @GiteaBot @6543