-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix renaming bug #1786
Fix renaming bug #1786
Conversation
LGTM |
LGTM, but it's strange why the CI reported build success? |
@lunny Usages of the old variable name had been added to master between when the PR CI ran and when the PR was merged into master. |
LGTM, even though it's already done 😄 |
@ethantkoenig if another PR merged, the CI should be restarted again? |
@lunny The CI only build master branch if PR merged. |
@lunny No, that would flood Drone (we already have a problem with CI jobs getting queued up) |
Fix oversight from #1766