Only run coverage on merges/pushes to master #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. This will need a new sign ( cc @lunny ) |
tboerger
added
the
lgtm/need 1
|
LGTM, @sapk it seems no need anymore? |
tboerger
added
lgtm/done
|
@lunny The CI build (https://drone.gitea.io/go-gitea/gitea/3191) has a warning |
Closed
appleboy
approved these changes
May 24, 2017
|
Please rebase master branch. |
|
trust LGTM |
|
Bad idea to do it like that, plugins don't support commands attribute |
|
@tboerger did you mean this PR will result the tag will not be released automatically? |
|
The added commands should be ignored |
lunny
added
the
topic/build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI builds are really slow (routinely over 40 minutes), and running the unit tests takes a large portion of the CI duration.
From running locally, it seems that running tests without coverage reports is much faster (~6x) than running with coverage reports (partly because they can be run in parallel, partly because shared code only needs to be compiled once). We don't really need coverage reports for commits/changes that aren't part of master, so only run a coverage report when changes are pushed/merged to master.
Changes the
make testto only runs test (no coverage report), and adds themake test-coveragerule for generating a coverage report.NOTE: needs signature for changes to
drone.yml