Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make side nav on dashboard stackable #1778

Merged
merged 1 commit into from
May 23, 2017
Merged

Make side nav on dashboard stackable #1778

merged 1 commit into from
May 23, 2017

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented May 22, 2017

@DblK
Copy link
Member

DblK commented May 22, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 22, 2017
@lunny lunny added this to the 1.2.0 milestone May 23, 2017
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label May 23, 2017
@lunny
Copy link
Member

lunny commented May 23, 2017

but CI failed

@DblK
Copy link
Member

DblK commented May 23, 2017

But error does not seems to be related to the pr "maximum time limit exceeded, build cancelled".
Maybe a restart could do the trick.

appleboy
appleboy approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@appleboy appleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restarted the build job.

@appleboy
Copy link
Member

@DblK Waiting build.

@sapk
Copy link
Member

sapk commented May 23, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2017
@appleboy appleboy merged commit cc2071c into go-gitea:master May 23, 2017
@pgaskin pgaskin deleted the patch-12 branch May 24, 2017 01:10
@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 25, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pgaskin @DblK @lunny @appleboy @sapk @tboerger