Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Display Github Actions results as plain HTML list #17755

Closed
wants to merge 13 commits into from

Conversation

velengel
Copy link
Contributor

ActionJobs
ActionsTab

@velengel velengel changed the title Display Github Actions results as plain HTML list Draft: Display Github Actions results as plain HTML list Nov 22, 2021
@wxiaoguang
Copy link
Contributor

Thank you for the PR.

But I think the goal of "Support GitHub Actions" is to make Gitea have similar features, not to make Gitea as a GitHub client.

And this implementation uses too many hard-coded constraint (like ghHostApiUrl), it's difficult to be used as a general feature by most users.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 22, 2021
@wxiaoguang wxiaoguang marked this pull request as draft November 22, 2021 11:39
@velengel
Copy link
Contributor Author

Thank you for your reply.

I understand the goal of "Support GitHub Actions" and the problem of this coding.

I'd appriciate your review!!

@velengel velengel closed this Nov 22, 2021
@ChristopherHX
Copy link
Contributor

ChristopherHX commented Dec 1, 2021

@velengel You are using an unstable api of my github actions reimplementation. I haven't thought about stabilizing it yet. I think the Goal is more to provide a gitea api that allows to upload job information, logs etc. to gitea and displaying them.

@wxiaoguang FYI
This is a client for my WIP opensource github action reimplementation (https://github.com/ChristopherHX/runner.server), GitHub doesn't offer that api on github.com.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants