Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport bugfixes #1220 and #1393 to v1.1 #1758

Merged
merged 3 commits into from
May 20, 2017
Merged

Conversation

agrn
Copy link
Contributor

@agrn agrn commented May 19, 2017

As requested by @lunny, I am backporting bugfixes #1220 and #1393 to v1.1. They fix the message "Error: No issue number specified" when pushing (bug #1111).

@lafriks
Copy link
Member

lafriks commented May 19, 2017

@lunny, just noticed - why is that empty github/issues.go file needed?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2017
@sapk
Copy link
Member

sapk commented May 19, 2017

LGTM as it is the exact backport and for the empty file it was added in #1220. I think it was removed since.

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2017
@sapk
Copy link
Member

sapk commented May 19, 2017

In fact #1326 removed it. Could you please remove it from this PR also ?

@lunny lunny added this to the 1.1.2 milestone May 19, 2017
@lunny lunny added the type/bug label May 19, 2017
@agrn
Copy link
Contributor Author

agrn commented May 19, 2017

OK

@lunny
Copy link
Member

lunny commented May 19, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 19, 2017
@lunny lunny merged commit 4fd55d8 into go-gitea:release/v1.1 May 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants