Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: integration test for nodeinfo #17346

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

techknowlogick
Copy link
Member

Add a minimal integration test for the nodeinfo endpoint added
in #16953

Signed-off-by: Loïc Dachary [email protected]

PR created on behalf of Loïc

Add a minimal integration test for the nodeinfo endpoint added
in go-gitea#16953

Signed-off-by: Loïc Dachary <[email protected]>
@techknowlogick techknowlogick added this to the 1.16.0 milestone Oct 18, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 18, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 18, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #17346 (3addca1) into main (db89504) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17346   +/-   ##
=======================================
  Coverage   45.16%   45.16%           
=======================================
  Files         784      784           
  Lines       88229    88229           
=======================================
+ Hits        39849    39850    +1     
+ Misses      41908    41901    -7     
- Partials     6472     6478    +6     
Impacted Files Coverage Δ
models/repo_mirror.go 60.41% <0.00%> (-10.42%) ⬇️
services/mirror/mirror.go 4.05% <0.00%> (-5.41%) ⬇️
modules/notification/mail/mail.go 35.29% <0.00%> (-2.95%) ⬇️
modules/cron/tasks_basic.go 85.43% <0.00%> (-2.92%) ⬇️
modules/log/event.go 60.64% <0.00%> (-1.86%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
modules/notification/ui/ui.go 60.86% <0.00%> (-1.45%) ⬇️
models/notification.go 65.28% <0.00%> (-0.88%) ⬇️
models/issue_comment.go 51.31% <0.00%> (-0.59%) ⬇️
services/pull/pull.go 41.78% <0.00%> (-0.41%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a6717...3addca1. Read the comment docs.

@techknowlogick techknowlogick merged commit 3397fee into go-gitea:main Oct 18, 2021
@techknowlogick techknowlogick deleted the nodeinfo-tests branch October 18, 2021 05:37
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants