Raw file API: don't try to interpret 40char filenames as commit SHA (#17185) #17272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stripped down backport of #17185, fixes #17179.
Don't try to interpret treepath as commit hash when path contains no hash-path-separator ('/')
Entering this case when
path
does not contain a '/' doesn't reallymake sense, as that means the tree path is empty, but this case is only
entered for routes that expect a non-empty tree path.
Treepaths like
<40-char-filename>
will now work, while paths like<40-char-dirname>/<filename>
will still fail,but hopefully don't occur that often. A more complete fix that avoids
this case too is outlined in #17185, but is too big of a change to functionality to backport