Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong i18n keys #17150

Merged
merged 3 commits into from
Sep 25, 2021
Merged

Fix wrong i18n keys #17150

merged 3 commits into from
Sep 25, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 25, 2021

As title.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.15 labels Sep 25, 2021
@lunny lunny added this to the 1.16.0 milestone Sep 25, 2021
@lunny lunny mentioned this pull request Sep 25, 2021
Merged
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2021
@6543

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 25, 2021
zeripath
zeripath approved these changes Sep 25, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mea culpa

@6543 6543 merged commit 58d8183 into go-gitea:main Sep 25, 2021
6543 added a commit to 6543-forks/gitea that referenced this pull request Sep 25, 2021
@lunny @6543
Fix wrong i18n keys (go-gitea#17150)
f5676ca 
Co-authored-by: 6543 <[email protected]>
@6543 6543 mentioned this pull request Sep 25, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Sep 25, 2021
@6543
Copy link
Member

6543 commented Sep 25, 2021

-> #17153

@lunny lunny deleted the lunny/fix_twofactor_i18n branch September 25, 2021 16:01
lunny added a commit that referenced this pull request Sep 26, 2021
@6543 @lunny
Fix wrong i18n keys (#17150) (#17153)
122917f 
Co-authored-by: 6543 <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @6543 @zeripath @wxiaoguang @GiteaBot