Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique constraint back into issue_index #16938

Merged

Commits on Sep 3, 2021

  1. Add unique constraint back into issue_index

    There is a flaw in go-gitea#16820 where it was missed that although xorm will
    not add a primary key to a table during syncing, it will remove an
    unique constraint.
    
    Users upgrading from 1.15.0 to 1.15.1 will therefore lose the unique
    constraint that makes this table work unless they run `gitea doctor
    recreate-table issue_index`.  Postgres helpfully warns about this
    situation but MySQL does not.
    
    Main/1.16-dev is not affected by this issue as there is a migration that
    does the above recreation by default. Users moving directly to 1.15.1
    from 1.14.x or lower are also not affected.
    
    Whilst we could force all users who ran 1.15.0 to do the above
    recreate-table call, this PR proposes an alternative: Just add the
    unique constraint back in for 1.15.x. This won't have any long term
    effects - just some wasted space for the unnecessary index.
    
    Fix go-gitea#16936
    
    Signed-off-by: Andrew Thornton <[email protected]>
    zeripath committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    1d2e46c View commit details
    Browse the repository at this point in the history