Enforce netgo build tag while cross-compilation #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2017
Closed
|
LGTM |
tboerger
added
the
lgtm/need 1
|
It would be better if it was a var like CROSSTAGS that default to netgo and maybe remove it from Dockerfile if not needed anymore. Otherwise LGTM. |
tboerger
added
lgtm/done
|
This should be backport to v1.1.2 since it's critical and will affect v1.1.1 |
appleboy
approved these changes
May 7, 2017
|
LGTM |
|
@sapk but for now it's enough. Maybe another PR to do that. |
|
@lunny that why I still LGTM. I think that one time I will search PR with "Otherwise LGTM" for making the changes ^^ |
|
This hasn't been backported yet, right? |
|
Yes. Maybe someone could do that so that we can put it in v1.1.2 |
cez81
pushed a commit
to cez81/gitea
that referenced
this pull request
May 17, 2017
lunny
pushed a commit
that referenced
this pull request
May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always enforce the builtin name resolution for cross-compiled binaries to prevent CGO executions.
Fixes #1168
Fixes #1684
Fixes #1408
Fixes #1500