Add configuration option for default permission to create Organizations #1686
Conversation
…reate Organizations
|
LGTM |
tboerger
added
the
lgtm/need 1
conf/app.ini
Outdated
| @@ -240,6 +240,9 @@ ENABLE_CAPTCHA = true | |||
| ; Default value for KeepEmailPrivate | |||
| ; New user will get the value of this setting copied into their profile | |||
| DEFAULT_KEEP_EMAIL_PRIVATE = false | |||
| ; Default value for AllowCreateOrganization | |||
| ; New user will get the value of this setting copied into their profile | |||
| DEFAULT_ALLOW_CREATE_ORGANIZATION = false | |||
There was a problem hiding this comment.
Default to true otherwise backwards compatability is broken.
| @@ -45,12 +45,12 @@ | |||
| margin: 0; | |||
|
|
|||
| dd { | |||
| margin-left: 240px; | |||
| margin-left: 275px; | |||
There was a problem hiding this comment.
Why was this change necessary? Got any screenshots of how it looks before and after?
There was a problem hiding this comment.
Otherwise "Default permission to create Organizations" did not if in, it was cut to something like "Default permission to crea..."
| } | ||
| dt { | ||
| font-weight: bolder; | ||
| float: left; | ||
| width: 250px; | ||
| width: 285px; |
| @@ -972,6 +972,7 @@ var Service struct { | |||
| EnableReverseProxyAutoRegister bool | |||
| EnableCaptcha bool | |||
| DefaultKeepEmailPrivate bool | |||
| DefaultAllowCreateOrganization bool | |||
There was a problem hiding this comment.
This has to default to true to not break the old behaviour
|
Please update the default behavior as @bkcsoft suggestions. Otherwise L-G-T-M |
modules/setting/setting.go
Outdated
| @@ -992,6 +993,7 @@ func newService() { | |||
| Service.EnableReverseProxyAutoRegister = sec.Key("ENABLE_REVERSE_PROXY_AUTO_REGISTRATION").MustBool() | |||
| Service.EnableCaptcha = sec.Key("ENABLE_CAPTCHA").MustBool() | |||
| Service.DefaultKeepEmailPrivate = sec.Key("DEFAULT_KEEP_EMAIL_PRIVATE").MustBool() | |||
| Service.DefaultAllowCreateOrganization = sec.Key("DEFAULT_ALLOW_CREATE_ORGANIZATION").MustBool() | |||
There was a problem hiding this comment.
You need to set default to true here. Changing app.ini doesn't do anything
|
Changed default to keep backward compatibility but I would like gitea to reconsider more sane default in the future. When adding this setting it should have not introduced such changes in default behavior. I see it could be useful only in deployments where gitea is used as SasS, in private repositories there would mostly also be only one person who will create organizations, in organizations that will do administrators. |
|
LGTM |
|
LG-TM, please work :) |
tboerger
added
lgtm/done
Defaults to false