Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gofmt error. #168

Merged
merged 1 commit into from
Nov 14, 2016
Merged

fix gofmt error. #168

merged 1 commit into from
Nov 14, 2016

Conversation

appleboy
Copy link
Member

Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin data should modify by generator?

@codecov-io
Copy link

codecov-io commented Nov 14, 2016

Current coverage is 3.03% (diff: 100%)

Merging #168 into master will not change coverage

@@            master      #168   diff @@
========================================
  Files           33        33          
  Lines         8096      8096          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7830      7830          
  Partials        20        20          

Powered by Codecov. Last update 904deb7...5054020

@strk
Copy link
Member

strk commented Nov 14, 2016

Agreed, bindata should not be included

Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy
Copy link
Member Author

@strk @lunny My apologies. I removed bindata.

@strk
Copy link
Member

strk commented Nov 14, 2016

LGTM

1 similar comment
@bkcsoft
Copy link
Member

bkcsoft commented Nov 14, 2016

LGTM

@andreynering andreynering merged commit 81f227e into go-gitea:master Nov 14, 2016
@appleboy appleboy deleted the gofmt branch November 15, 2016 00:51
@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 15, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 15, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants