Fix commit sha1 URL rendering in markdown #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
reviewed
May 4, 2017
| @@ -296,6 +296,7 @@ func TestRender_Commits(t *testing.T) { | |||
| test(sha, `<p><a href="`+commit+`" rel="nofollow">b6dd6210ea</a></p>`) | |||
| test(commit, `<p><a href="`+commit+`" rel="nofollow">b6dd6210ea</a></p>`) | |||
| test(tree, `<p><a href="`+src+`" rel="nofollow">b6dd6210ea/src</a></p>`) | |||
| test("commit "+sha, `<p>commit <a href="`+commit+`" rel="nofollow">b6dd6210ea</a></p>`) | |||
There was a problem hiding this comment.
I won't ask for this PR but it would be better if the short sha is not hardcoded but derived from sha in test result (in the future ^^).
sapk
reviewed
May 4, 2017
modules/markdown/markdown.go
Outdated
| @@ -542,7 +542,7 @@ func RenderCrossReferenceIssueIndexPattern(rawBytes []byte, urlPrefix string, me | |||
| func renderSha1CurrentPattern(rawBytes []byte, urlPrefix string) []byte { | |||
| ms := Sha1CurrentPattern.FindAllSubmatch(rawBytes, -1) | |||
| for _, m := range ms { | |||
| all := m[0] | |||
| all := m[1] | |||
There was a problem hiding this comment.
I think we should not call it all now that it right fully catch only the commitId/sha1.
|
I have made two comments that are non blocking just improvement. Otherwise LGTM. |
tboerger
added
the
lgtm/need 1
appleboy
approved these changes
May 5, 2017
|
LGTM |
tboerger
added
lgtm/done
|
Changed variable name as requested :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1667