Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link for Contributors Guide #166

Merged
merged 2 commits into from
Nov 14, 2016
Merged

Fix broken link for Contributors Guide #166

merged 2 commits into from
Nov 14, 2016

Conversation

appleboy
Copy link
Member

as title.

tboerger
tboerger reviewed Nov 14, 2016
View reviewed changes
README.md
@@ -21,7 +21,7 @@

### Important Notes

1. **YOU MUST READ THE [Contributors Guide](https://github.com/go-gitea/gitea/CONTRIBUTING.md) BEFORE STARTING TO WORK ON A PULL REQUEST**.
1. **YOU MUST READ THE [Contributors Guide](./CONTRIBUTING.md) BEFORE STARTING TO WORK ON A PULL REQUEST**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even the./ is optional :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could remove ./? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on that. If you say lgtm feel free to merge it like it is

@tboerger
Copy link
Member

LGTM

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Nov 14, 2016
@lunny lunny added this to the 1.0.0 milestone Nov 14, 2016
@codecov-io
Copy link

codecov-io commented Nov 14, 2016 •
edited
Loading

Current coverage is 3.03% (diff: 100%)

Merging #166 into master will not change coverage

@@            master      #166   diff @@
========================================
  Files           33        33          
  Lines         8096      8096          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7830      7830          
  Partials        20        20

Powered by Codecov. Last update 739f07c...e206d48

@appleboy
Copy link
Member Author

Done. Please squash and merge.

@lunny
Copy link
Member

lunny commented Nov 14, 2016

LGTM

@tboerger tboerger merged commit 904deb7 into go-gitea:master Nov 14, 2016
@appleboy appleboy deleted the patch-2 branch November 14, 2016 07:41
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Apr 29, 2017
@bspidel
Remove Hashtag Code from Build (go-gitea#166)
5fa9875 
* Remove Hashtag Code from Build

Hashtag code was added prematurely.

feature/Issue-162

* removed reference to db
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@tboerger tboerger tboerger left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@appleboy @tboerger @codecov-io @lunny