Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown translation key #16057

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Fix unknown translation key #16057

merged 2 commits into from
Jun 3, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jun 2, 2021

Regression of #15735

@KN4CK3R KN4CK3R added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Jun 2, 2021
@KN4CK3R KN4CK3R added this to the 1.15.0 milestone Jun 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16057 (fc3650d) into main (c1ff59c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16057      +/-   ##
==========================================
- Coverage   44.07%   44.04%   -0.04%     
==========================================
  Files         682      682              
  Lines       82457    82457              
==========================================
- Hits        36347    36319      -28     
- Misses      40189    40218      +29     
+ Partials     5921     5920       -1     
Impacted Files Coverage Δ
services/mailer/mail_comment.go 77.77% <0.00%> (-7.41%) ⬇️
modules/queue/queue_channel.go 91.66% <0.00%> (-5.00%) ⬇️
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/queue/workerpool.go 54.19% <0.00%> (-2.30%) ⬇️
modules/notification/mail/mail.go 37.89% <0.00%> (-2.11%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
routers/repo/view.go 40.66% <0.00%> (-0.59%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ff59c...fc3650d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 2, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 3, 2021
@zeripath
Copy link
Contributor

zeripath commented Jun 3, 2021

Make lgtm work

@zeripath zeripath merged commit 8e5a37c into go-gitea:main Jun 3, 2021
@KN4CK3R KN4CK3R deleted the patch-1 branch June 5, 2021 15:43
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants