Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only log Error on getLastCommitStatus error to let pull list still be visible (#15716) #15715

Merged
merged 2 commits into from
May 4, 2021
Merged

Only log Error on getLastCommitStatus error to let pull list still be visible (#15716) #15715

merged 2 commits into from
May 4, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented May 4, 2021 •
edited
Loading

Backport of #15716

@6543 6543 added the type/bug label May 4, 2021
@6543 6543 added this to the 1.14.2 milestone May 4, 2021
@6543 6543 changed the title Only log Error on getLastCommitStatus error to let pull list still be visible Only log Error on getLastCommitStatus error to let pull list still be visible (#15716) May 4, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2021
@6543
Copy link
Member Author

6543 commented May 4, 2021

🚀

@6543 6543 merged commit f1e8b8c into go-gitea:release/v1.14 May 4, 2021
@6543 6543 deleted the pull-list_skip-lastCommitStatus-if-err branch May 4, 2021 12:03
@zeripath zeripath mentioned this pull request May 8, 2021
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @KN4CK3R @zeripath @GiteaBot