Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conn.SetDeadline
will set a timeout based on connection succeed but not per request. Since a connection maybe resued for multiple http requests. This will result in many timeout on webhook requests.This PR fix the problem which also found in gitea.com
This PR also changed a similiar problem on
httplib
. Because it will always create a new client when request, so it will not be affected currently. But creating a new client per request is really a problem should be fixed.