Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE on view commit with notes (#15561) #15573

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 21, 2021

Backport #15561

There is a mistake with the native git variant of GetNote when the note is referring to a non-root path.

This PR simply splits the path and passes the basedir into GetLastCommitPaths separate from the root path.

Fix #15558

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added this to the 1.14.2 milestone Apr 21, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2021
@techknowlogick techknowlogick merged commit 248b67a into go-gitea:release/v1.14 Apr 21, 2021
@zeripath zeripath deleted the backport-15561-v1.14 branch April 21, 2021 19:20
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants