Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response 404 for diff/patch of a commit that not exist (#15221) #15238

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

a1012112796
Copy link
Member

Backport #15221

* response 404 for diff/patch of a commit that not exist

fix go-gitea#15217

Signed-off-by: a1012112796 <[email protected]>

* Update routers/repo/commit.go

Co-authored-by: silverwind <[email protected]>

* use ctx.NotFound()

Co-authored-by: zeripath <[email protected]>
Co-authored-by: silverwind <[email protected]>
@a1012112796 a1012112796 added this to the 1.13.7 milestone Apr 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 1, 2021
@zeripath
Copy link
Contributor

zeripath commented Apr 2, 2021

make lgtm work

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2021
@zeripath zeripath merged commit 0d7afb0 into go-gitea:release/v1.13 Apr 2, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
@a1012112796 a1012112796 deleted the backport/15221-2 branch May 17, 2023 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants