Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go get sub package and add domain on installation to let go get work defaultly #1518

Merged
merged 3 commits into from
Apr 21, 2017
Merged

fix go get sub package and add domain on installation to let go get work defaultly #1518

merged 3 commits into from
Apr 21, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 20, 2017

fix #1485

@lunny lunny added the type/bug label Apr 20, 2017
@lunny lunny added this to the 1.2.0 milestone Apr 20, 2017
cez81
cez81 reviewed Apr 20, 2017
View reviewed changes
routers/repo/http.go Outdated
@@ -17,18 +17,42 @@ import (
"strings"
"time"

"github.com/Unknwon/com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External after local imports?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch and done.

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2017
@strk
Copy link
Member

strk commented Apr 20, 2017

LGTM but it will look much better if it came with unit tests.
@lunny, as an owner, you should be an example to others ! :)

@lunny
Copy link
Member Author

lunny commented Apr 20, 2017

@strk in fact, the unit tests depends on integration test framework. I think I will do that after that's ready.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2017
@lunny lunny mentioned this pull request Apr 20, 2017
Closed
@lunny
Copy link
Member Author

lunny commented Apr 21, 2017

let L-G-T-M work

@lunny lunny merged commit f0db3da into go-gitea:master Apr 21, 2017
@lunny lunny deleted the lunny/fix_go_get branch April 21, 2017 02:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cez81 cez81 cez81 left review comments

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Make go packages from subdirectories on gitea instances installable with "go get"
5 participants
@lunny @appleboy @strk @cez81 @tboerger