Skip to content

bug fixed for 500 caused by get org users#149

Merged
lunny merged 1 commit intogo-gitea:masterfrom
lunny:lunny/bug_fixed_500_org
Nov 11, 2016
Merged

bug fixed for 500 caused by get org users#149
lunny merged 1 commit intogo-gitea:masterfrom
lunny:lunny/bug_fixed_500_org

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 11, 2016

This is not related with #147.

@bkcsoft
Copy link
Contributor

bkcsoft commented Nov 11, 2016

@lunny how does this fix that issue?

@lunny
Copy link
Member Author

lunny commented Nov 11, 2016

" is only quote of postgres, so mysql will report error. ` is a common quote on XORM, XORM will replace it to every database's quote.

@bkcsoft
Copy link
Contributor

bkcsoft commented Nov 11, 2016

But it's only for when an Org doesn't have any Repos. If this was the error, it should happen all the time and not just in that case?

@lunny
Copy link
Member Author

lunny commented Nov 11, 2016

No. I make mistake. These two bugs. #147 and #149. They are different bugs.

@codecov-io
Copy link

codecov-io commented Nov 11, 2016

Current coverage is 3.03% (diff: 0.00%)

Merging #149 into master will not change coverage

@@            master      #149   diff @@
========================================
  Files           33        33          
  Lines         8096      8096          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7830      7830          
  Partials        20        20          

Powered by Codecov. Last update e2aa991...ebab077

@thibaultmeyer
Copy link
Contributor

LGTM

@thibaultmeyer thibaultmeyer added this to the 1.0.0 milestone Nov 11, 2016
@bkcsoft
Copy link
Contributor

bkcsoft commented Nov 11, 2016

LGTM

@lunny lunny merged commit 9bf28a2 into go-gitea:master Nov 11, 2016
@lunny lunny deleted the lunny/bug_fixed_500_org branch November 11, 2016 16:57
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants