Fix races in the log module by using syncmap #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trusted LGTM (and let's see what the Debian packager has to say about the new dependency) |
tboerger
added
the
lgtm/need 1
|
I imagine the vim swap file was an oops but otherwise think this looks like a clean and sane dependency that could be valuable for many other projects as well. |
|
LGTM |
tboerger
added
lgtm/done
|
@MTecknology Fixed. |
|
@typeless may I suggest to squash-rebase this on your side to avoid the git log bloat introduced by the github "squash-and-merge" button ? |
typeless
force-pushed
the
fix-races-by-using-syncmap
branch
from
24b5fa8
to
a87f98a
Compare
|
@strk Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use syncmap instead of map + mutex locks.
Fix #1412