Add length check for the return string #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
requested changes
Mar 31, 2017
models/pull.go
Outdated
| @@ -508,7 +508,7 @@ func (pr *PullRequest) getMergeCommit() (*git.Commit, error) { | |||
| []string{"GIT_INDEX_FILE=" + indexTmpPath, "GIT_DIR=" + pr.BaseRepo.RepoPath()}, | |||
| "git", "rev-list", "--ancestry-path", "--merges", "--reverse", cmd) | |||
|
|
|||
| if err != nil { | |||
| if err != nil || len(mergeCommit) != 40 { | |||
There was a problem hiding this comment.
if err == nil && len(mergeCommit) != 40 {
err = errors.New("...")
}
if err != nil {
return ...
}
lunny
reviewed
Mar 31, 2017
models/pull.go
Outdated
| @@ -507,7 +507,9 @@ func (pr *PullRequest) getMergeCommit() (*git.Commit, error) { | |||
| mergeCommit, stderr, err := process.GetManager().ExecDirEnv(-1, "", fmt.Sprintf("isMerged (git rev-list --ancestry-path --merges --reverse): %d", pr.BaseRepo.ID), | |||
| []string{"GIT_INDEX_FILE=" + indexTmpPath, "GIT_DIR=" + pr.BaseRepo.RepoPath()}, | |||
| "git", "rev-list", "--ancestry-path", "--merges", "--reverse", cmd) | |||
|
|
|||
| if err == nil && len(mergeCommit) != 40 { | |||
| err = fmt.Errorf("git rev-list --ancestry-path --merges --reverse: unexpected length of output (got:%d bytes)", len(mergeCommit)) | |||
lunny
approved these changes
Mar 31, 2017
|
LGTM |
tboerger
added
the
lgtm/need 1
appleboy
approved these changes
Mar 31, 2017
|
LGTM |
tboerger
added
lgtm/done
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the check, it could lead to out-of-bound panic if the return string is shorter than expected.