Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data races in the logger module #1414

Closed
wants to merge 7 commits into from
Closed

Fix data races in the logger module #1414

wants to merge 7 commits into from

Commits on Mar 30, 2017

  1. Fix data races

    @typeless
    typeless committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    bce07fd View commit details
    Browse the repository at this point in the history

  2. Follow the defer pattern

    @typeless
    typeless committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    38e7ce3 View commit details
    Browse the repository at this point in the history

  3. Remove -race. This shouldn't be in production code.

    @typeless
    typeless committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    1915793 View commit details
    Browse the repository at this point in the history

  4. Follow the defer-unlock pattern

    @typeless
    typeless committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    7974b2a View commit details
    Browse the repository at this point in the history

  5. Avoid deadlocks

    @typeless
    typeless committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    67278d2 View commit details
    Browse the repository at this point in the history

  6. Use RWMutex instead of Mutex 

    And locking the shared data structure accurately.
    @typeless
    typeless committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    31394cf View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2017

  1. Fix read-and-update race

    @typeless
    typeless committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    f20a686 View commit details
    Browse the repository at this point in the history