Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FCGI (over TCP) support #1368

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Fix FCGI (over TCP) support #1368

merged 1 commit into from
Mar 23, 2017

Conversation

pkorovin
Copy link
Contributor

Although basic FCGI support is present since 2014 (gogs/gogs#601), it's not usable.
This commit adds support for serving via FCGI protocol over tcp socket.
The socket address:port is derived from HTTP_ADDR and HTTP_PORT configuration settings.
Tested on OpenBSD-current with OpenBSD's httpd.

@lunny lunny added this to the 1.2.0 milestone Mar 22, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 22, 2017
@strk
Copy link
Member

strk commented Mar 22, 2017

Could you please also send an integration to https://docs.gitea.io/en-us/config-cheat-sheet/ ?
It'd go in https://github.com/go-gitea/docs/blob/master/content/doc/advanced/config-cheat-sheet.en-us.md

(as I don't find any FCGI mention in there...)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2017
@pkorovin pkorovin mentioned this pull request Mar 22, 2017
Merged
@strk
Copy link
Member

strk commented Mar 23, 2017

LGTM now that I red go-gitea/docs#107 (please merge that one too!)

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 23, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2017
@appleboy appleboy merged commit ae9b02b into go-gitea:master Mar 23, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pkorovin @strk @appleboy @lunny @tboerger