Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include formatting check to the make test (and thus also check) rule #1366

Merged
merged 4 commits into from
Jun 6, 2017
Merged

Include formatting check to the make test (and thus also check) rule #1366

merged 4 commits into from
Jun 6, 2017
+21 −7

Commits on Jun 6, 2017

  1. Forbid running "make fmt" with Go version != 1.7 or 1.8

    @strk
    strk committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    6fe0997 View commit details
    Browse the repository at this point in the history

  2. Include formatting check to the make check rule 

    ... and give it its own standalone target too (make fmt-check)

Show diff on fmt-check failure
Do not allow running "fmt-check" with incompatible go version
Also simplify the `fmt` rule
    @strk
    strk committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    c8d6f3a View commit details
    Browse the repository at this point in the history

  3. Ignore bindata.go for spelling and formatting checks 

    also remove duplicated variable assignment for GOFILES
    @strk
    strk committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    a7649a1 View commit details
    Browse the repository at this point in the history

  4. Run make fmt

    @strk
    strk committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    5513ef0 View commit details
    Browse the repository at this point in the history