Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFS: Return 404 for unimplemented endpoints #1330

Merged
merged 1 commit into from
Mar 20, 2017
Merged

LFS: Return 404 for unimplemented endpoints #1330

merged 1 commit into from
Mar 20, 2017

Conversation

fabian-z
Copy link
Contributor

@fabian-z fabian-z commented Mar 19, 2017 •
edited
Loading

Without this change a 401 is returned for unspecified endpoints, making the LFS client ask for HTTP credentials. This behaviour was introduced with the new locking API:

https://github.com/git-lfs/git-lfs/blob/master/docs/api/locking.md

git-lfs trace before and after patch:

trace git-lfs: ssh: fabian@localhost git-lfs-authenticate test/test.git upload
trace git-lfs: HTTP: POST http://localhost:3000/test/test.git/info/lfs/locks/verify
trace git-lfs: HTTP: 401
trace git-lfs: setting repository access to basic

trace git-lfs: ssh: fabian@localhost git-lfs-authenticate test/test.git upload
trace git-lfs: HTTP: POST http://localhost:3000/test/test.git/info/lfs/locks/verify
trace git-lfs: HTTP: 404
Remote "origin" does not support the LFS locking API. Consider disabling it with:
$ git config 'lfs.https://localhost/test/test.git/info/lfs.locksverify' false

@fabian-z
LFS: Return 404 for unimplemented endpoints
a005826 
Without this patch a 401 is returned for unspecified endpoints, making
the LFS client ask for HTTP credentials. This behaviour was introduced
with the new locking API:

https://github.com/git-lfs/git-lfs/blob/master/docs/api/locking.md
@lunny lunny added this to the 1.2.0 milestone Mar 20, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 20, 2017
@lunny
Copy link
Member

lunny commented Mar 20, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 20, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2017
@lunny lunny merged commit 5586445 into go-gitea:master Mar 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fabian-z @lunny @appleboy @tboerger