allow U2F with default settings for gitea in subpath #12990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolheiser
approved these changes
Sep 30, 2020
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #12990 +/- ##
==========================================
- Coverage 42.59% 42.58% -0.01%
==========================================
Files 671 671
Lines 73625 73625
==========================================
- Hits 31363 31356 -7
- Misses 37183 37195 +12
+ Partials 5079 5074 -5
Continue to review full report at Codecov.
|
zeripath
approved these changes
Sep 30, 2020
GiteaBot
added
lgtm/done
|
Blocking this as it needs more testing. |
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Oct 1, 2020
zeripath
pushed a commit
that referenced
this pull request
Oct 1, 2020
* Refactor use TrimSuffix instead of TrimRight * TrimRight right * has #12990
|
Looking at the settings code it is definitely the case that the AppSubURL does not have a terminal "/" and it is always the case the the AppURL has a terminal slash - therefore the proposed PR is correctly stripping off the AppSubURL |
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 1, 2020
* allow U2F with default settings for gitea in subpath * use trim suffix Co-authored-by: zeripath <[email protected]>
techknowlogick
added
the
backport/done
techknowlogick
added a commit
that referenced
this pull request
Oct 1, 2020
* allow U2F with default settings for gitea in subpath * use trim suffix Co-authored-by: zeripath <[email protected]> Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credit to @zeripath for logic
Fix #10231
Likely fixes #5143