-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape more things that are passed through str2html #12622
Merged
techknowlogick
merged 4 commits into
go-gitea:master
from
zeripath:escape-before-str2html
Aug 28, 2020
Merged
Escape more things that are passed through str2html #12622
techknowlogick
merged 4 commits into
go-gitea:master
from
zeripath:escape-before-str2html
Aug 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
mrsdizzie
suggested changes
Aug 27, 2020
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Aug 27, 2020
Co-authored-by: mrsdizzie <[email protected]>
mrsdizzie
approved these changes
Aug 27, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Aug 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #12622 +/- ##
==========================================
+ Coverage 43.43% 43.44% +0.01%
==========================================
Files 645 645
Lines 71306 71306
==========================================
+ Hits 30972 30981 +9
+ Misses 35323 35317 -6
+ Partials 5011 5008 -3
Continue to review full report at Codecov.
|
zeripath
commented
Aug 27, 2020
techknowlogick
approved these changes
Aug 28, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 28, 2020
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 15, 2020
Backport go-gitea#12622 * Escape more things that are passed through str2html Signed-off-by: Andrew Thornton <[email protected]> * Bloody editors! Co-authored-by: mrsdizzie <[email protected]> * Update routers/user/oauth.go Co-authored-by: mrsdizzie <[email protected]> Co-authored-by: techknowlogick <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
Sep 15, 2020
Backport #12622 * Escape more things that are passed through str2html Signed-off-by: Andrew Thornton <[email protected]> * Bloody editors! Co-authored-by: mrsdizzie <[email protected]> * Update routers/user/oauth.go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Thornton [email protected]