Fix nil-dereference bug #1258
Merged
Fix nil-dereference bug #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
commented
Mar 15, 2017
| @@ -219,7 +219,11 @@ func RepoAssignment(args ...bool) macaron.Handler { | |||
| if ctx.IsSigned && ctx.User.IsAdmin { | |||
| ctx.Repo.AccessMode = models.AccessModeOwner | |||
| } else { | |||
| mode, err := models.AccessLevel(ctx.User.ID, repo) | |||
There was a problem hiding this comment.
ctx.User may be nil, so this doesn't work
lunny
reviewed
Mar 15, 2017
modules/context/repo.go
Outdated
| @@ -219,7 +219,11 @@ func RepoAssignment(args ...bool) macaron.Handler { | |||
| if ctx.IsSigned && ctx.User.IsAdmin { | |||
| ctx.Repo.AccessMode = models.AccessModeOwner | |||
| } else { | |||
| mode, err := models.AccessLevel(ctx.User.ID, repo) | |||
| userID := int64(0) | |||
There was a problem hiding this comment.
Maybe var userID int64 is better ?
ethantkoenig
force-pushed
the
fix/access
branch
from
217b1e1
to
5dbc21e
Compare
|
LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
strk
reviewed
Mar 15, 2017
| if ctx.User != nil { | ||
| userID = ctx.User.ID | ||
| } | ||
| mode, err := models.AccessLevel(userID, repo) |
There was a problem hiding this comment.
What happens if ctx.User is nil here ? What's the value of userID ? Is that value guaranteed to mean "anonymous user" ?
There was a problem hiding this comment.
Yes, userID=0 means anonymous user, see access.go: line 68
ethantkoenig
force-pushed
the
fix/access
branch
from
5dbc21e
to
99eb049
Compare
|
Rebased; the CI build wasn't running for some reason |
ethantkoenig
force-pushed
the
fix/access
branch
from
99eb049
to
17f403f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug introduced by #1247 where viewing a repository while not signed in a user causes a 500 (due to a nil pointer deference).