Skip to content

Conversation

@techknowlogick
Copy link
Member

fix #12262

@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 11, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12468 into master will decrease coverage by 0.07%.
The diff coverage is 36.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12468      +/-   ##
==========================================
- Coverage   43.88%   43.81%   -0.08%     
==========================================
  Files         614      630      +16     
  Lines       87607    69821   -17786     
==========================================
- Hits        38449    30591    -7858     
+ Misses      44421    34293   -10128     
- Partials     4737     4937     +200     
Impacted Files Coverage Δ
cmd/doctor.go 0.00% <0.00%> (ø)
cmd/generate.go 0.00% <0.00%> (ø)
cmd/hook.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/consistency.go 55.30% <0.00%> (-1.63%) ⬇️
models/context.go 40.00% <ø> (+0.71%) ⬆️
models/migrations/migrations.go 4.66% <ø> (+1.16%) ⬆️
models/migrations/v102.go 0.00% <0.00%> (ø)
models/migrations/v111.go 0.00% <0.00%> (ø)
... and 737 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a6705...5e355f2. Read the comment docs.

@techknowlogick techknowlogick merged commit 0cc21fb into go-gitea:master Aug 11, 2020
@techknowlogick techknowlogick deleted the fix-12262 branch August 11, 2020 02:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codecov doesn't seem to be working properly

5 participants