Skip to content

Update JS deps and linting config #12295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2020
Merged

Update JS deps and linting config #12295

merged 2 commits into from
Jul 27, 2020

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Jul 22, 2020

  • update js deps to latest versions
  • remove eslint-plugin-sonarjs to prevent a warning on install. can be added again once it's updated to support eslint 7.x
  • enable new linting rules from eslint-plugin-unicorn

@techknowlogick techknowlogick added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 23, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jul 23, 2020
@silverwind
Copy link
Member Author

silverwind commented Jul 25, 2020

Updated deps again, webpack and dropzone bumped.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 25, 2020
@lafriks lafriks requested a review from guillep2k July 25, 2020 21:02
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 25, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 27, 2020
@techknowlogick
Copy link
Member

techknowlogick commented Jul 27, 2020

please resolve conflicts :)

@silverwind
Update JS deps and linting config
2d6c842 
- update js deps to latest versions
- remove eslint-plugin-sonarjs to prevent a warning on install. can be
  added again once it's updated to support eslint 7.x
- enable new linting rules from eslint-plugin-unicorn
@silverwind
Copy link
Member Author

silverwind commented Jul 27, 2020

Resolved and pushed some more misc dependency updates: css-loader,mermaid and terser-webpack-plugin. The css-loader update did require a minor change in the webpack config as a function signature was changed. Looks to work well otherwise.

@techknowlogick
Copy link
Member

techknowlogick commented Jul 27, 2020

🚀

@techknowlogick techknowlogick merged commit 78cbd0c into go-gitea:master Jul 27, 2020
@silverwind silverwind deleted the deps-11 branch July 27, 2020 21:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@guillep2k guillep2k Awaiting requested review from guillep2k

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind @techknowlogick @lunny @lafriks @GiteaBot