Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify RepositoryList.loadAttributes() #1211

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Simplify RepositoryList.loadAttributes() #1211

merged 1 commit into from
Mar 11, 2017

Conversation

ethantkoenig
Copy link
Member

Remove unneeded variables and loops, and use common helper function keysInt64(..).

@lunny
Copy link
Member

lunny commented Mar 10, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 10, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 11, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 11, 2017
@strk
Copy link
Member

strk commented Mar 11, 2017

trusted LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2017
@lunny lunny merged commit c99e7e1 into go-gitea:master Mar 11, 2017
@ethantkoenig ethantkoenig deleted the refactor/repo_list branch March 13, 2017 17:26
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ethantkoenig @lunny @strk @tboerger