Disable go module when downloading global binaries #12030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent `go get` from touching `go.mod` and `go.sum` when executing global binaries during the build process. Once golang/go#30515 is fixed, we should is whatever solution is provided there. Fixes: go-gitea#12010
zeripath
approved these changes
Jun 24, 2020
GiteaBot
added
the
lgtm/need 1
techknowlogick
added
topic/build
techknowlogick
approved these changes
Jun 26, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
Jun 26, 2020
|
Sorry for nagging, but this is going to be included in an upcoming 1.12 release? I think it would be required to complete the upgrade of the FreeBSD package. |
stblassitude
pushed a commit
to stblassitude/gitea
that referenced
this pull request
Jun 28, 2020
Prevent `go get` from touching `go.mod` and `go.sum` when executing global binaries during the build process. Once golang/go#30515 is fixed, we should is whatever solution is provided there. Fixes: go-gitea#12010 Co-authored-by: techknowlogick <[email protected]>
techknowlogick
added
backport/v1.12
backport/done
lafriks
pushed a commit
that referenced
this pull request
Jun 28, 2020
Prevent `go get` from touching `go.mod` and `go.sum` when executing global binaries during the build process. Once golang/go#30515 is fixed, we should is whatever solution is provided there. Fixes: #12010 Co-authored-by: techknowlogick <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: techknowlogick <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Prevent `go get` from touching `go.mod` and `go.sum` when executing global binaries during the build process. Once golang/go#30515 is fixed, we should is whatever solution is provided there. Fixes: go-gitea#12010 Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent
go getfrom touchinggo.modandgo.sumwhen executing global binaries during the build process. Once golang/go#30515 is fixed, we should is whatever solution is provided there.Fixes: #12010