Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LibreJS support #1201

Merged
merged 1 commit into from
Mar 12, 2017
Merged

Add LibreJS support #1201

merged 1 commit into from
Mar 12, 2017

Conversation

strk
Copy link
Member

@strk strk commented Mar 10, 2017

@lunny
Copy link
Member

lunny commented Mar 11, 2017

Why we need to add this?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2017
@strk
Copy link
Member Author

strk commented Mar 11, 2017

We want (not need) this to properly advertise the license of the Javascript code we ask users to execute.
Some users don't want to run proprietary software so refuse to run Javascript code if it's not free software. There are browser plugins for that. You can read more about the rationale (the "Javascript trap") in the link placed in the original submission.

@strk
Copy link
Member Author

strk commented Mar 11, 2017

Reporting the link here: https://www.gnu.org/philosophy/javascript-trap.html

@pgaskin
Copy link
Contributor

pgaskin commented Mar 12, 2017

This should be merged because it is not a big change, and it will make managing the licenses of different libraries easier.

@lunny
Copy link
Member

lunny commented Mar 12, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 12, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 12, 2017
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Mar 12, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 12, 2017
@lunny lunny merged commit f0efb61 into go-gitea:master Mar 12, 2017
@strk strk deleted the librejs branch March 15, 2017 09:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Add LibreJS support
5 participants
@strk @lunny @pgaskin @appleboy @tboerger