Skip to content

Conversation

@zeripath
Copy link
Contributor

Update to go-git v5.1.0.

Fix #9938

Signed-off-by: Andrew Thornton [email protected]

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.13.0 milestone Jun 17, 2020
@zeripath
Copy link
Contributor Author

I suspect that we should probably backport this to 1.12 and possibly 1.11 as #9938 badly affects our FreeBSD users.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 17, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 17, 2020
@techknowlogick
Copy link
Member

I can confirm the fix is there, @kevans91's PR go-git/go-git#39 is included in 5.1.0 release of go-git per the release notes: https://github.com/go-git/go-git/releases/tag/v5.1.0 (and I can also see the code change in the vendor dir)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2020
@6543
Copy link
Member

6543 commented Jun 17, 2020

"backport" -> #11941

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jun 17, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 1426126 into go-gitea:master Jun 17, 2020
lunny pushed a commit that referenced this pull request Jun 18, 2020
* update go-git 5.0.0 -> v5.1.0

* vendor

Co-authored-by: techknowlogick <[email protected]>
@zeripath zeripath deleted the go-git-5.10 branch June 18, 2020 07:56
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sub-branches throw 500

4 participants