Skip to content

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 6, 2020

Backport #10943 #10990 #10064 #9095

Signed-off-by: Andrew Thornton [email protected]
Co-authored-by: guillep2k [email protected]
Co-authored-by: John Olheiser [email protected]
Co-authored-by: Lunny Xiao [email protected]

Backport go-gitea#10943

* Add `gitea doctor --list` flag to list the checks that will be run, including those by default
* Add `gitea doctor --run` to run specific checks
* Add `gitea doctor --all` to run all checks
* Add db version checker
* Add non-default recalculate merge bases check/fixer to doctor
* Add hook checker (Fix go-gitea#9878) and ensure hooks are executable (Fix go-gitea#6319)
* Fix authorized_keys checker - slight change of functionality here because parsing the command is fragile and we should just check if the authorized_keys file is essentially the same as what gitea would produce. (This is still not perfect as order matters - we should probably just md5sum the two files.)
* Add SCRIPT_TYPE check (Fix go-gitea#10977)
* Add `gitea doctor --fix` to attempt to fix what is possible to easily fix
* Add `gitea doctor --log-file` to set the log-file, be it a file, stdout or to switch off completely. (Fixes previously undetected bug with certain xorm logging configurations - see @6543 comment.)

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 6, 2020
@zeripath zeripath added this to the 1.11.5 milestone Apr 6, 2020
@lafriks
Copy link
Member

lafriks commented Apr 6, 2020

Undefined io.StringWriter

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 6, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2020
@techknowlogick techknowlogick merged commit c34ad62 into go-gitea:release/v1.11 Apr 6, 2020
@zeripath zeripath deleted the backport-10943-doctor branch April 6, 2020 21:49
@6543
Copy link
Member

6543 commented May 8, 2020

is kind/build the right label for this?

@zeripath zeripath added type/enhancement An improvement of existing functionality and removed topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels May 8, 2020
@zeripath zeripath changed the title Mulitple Gitea Doctor improvements (#10943) (#10990) (#10064) (#9095) Multiple Gitea Doctor improvements (#10943) (#10990) (#10064) (#9095) May 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants