Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed custom templates for static builds #1087

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Fixed custom templates for static builds #1087

merged 1 commit into from
Mar 1, 2017

Conversation

tboerger
Copy link
Member

Now the custom templates are finally back! 💣

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Feb 28, 2017
@tboerger tboerger added this to the 1.1.0 milestone Feb 28, 2017
"github.com/gorilla/sessions"
"github.com/markbates/goth"
"github.com/markbates/goth/gothic"
"github.com/markbates/goth/providers/github"
"github.com/satori/go.uuid"
"net/http"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coding style about import sorter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not my code, this change is anyway only there because it have not been formatted

@tboerger
Copy link
Member Author

Dann, got to add back the bindata package

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2017
@tboerger
Copy link
Member Author

Ready for review

@andreynering
Copy link
Contributor

Trusted LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2017
@lunny
Copy link
Member

lunny commented Mar 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2017
@lunny lunny merged commit db6777d into go-gitea:master Mar 1, 2017
@lunny lunny mentioned this pull request Mar 1, 2017
6 tasks
@tboerger tboerger deleted the custom-templates branch March 9, 2017 15:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants