Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Feb 24, 2020

as title

@6543 6543 changed the title [WIP] fix a pagination bug FIX Pagination of ListAccessTokens and GetIssueWatchers Feb 24, 2020
@6543
Copy link
Member Author

6543 commented Feb 24, 2020

fix pagination introduced in #9452

so lable: skip-changelog

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2020
@guillep2k guillep2k added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 24, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2020
@6543
Copy link
Member Author

6543 commented Feb 24, 2020

@guillep2k thx

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #10449 into master will increase coverage by <.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10449      +/-   ##
==========================================
+ Coverage   43.68%   43.68%   +<.01%     
==========================================
  Files         586      586              
  Lines       81389    81391       +2     
==========================================
+ Hits        35552    35556       +4     
  Misses      41433    41433              
+ Partials     4404     4402       -2
Impacted Files Coverage Δ
models/token.go 73.77% <0%> (-6.56%) ⬇️
models/issue_watch.go 58.53% <50%> (-5.22%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0%> (-1.93%) ⬇️
routers/repo/view.go 36.06% <0%> (-0.69%) ⬇️
models/gpg_key.go 54.81% <0%> (-0.56%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (ø) ⬆️
models/error.go 29.23% <0%> (+0.51%) ⬆️
services/pull/pull.go 36.07% <0%> (+0.87%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eeee9c...fa62db9. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Feb 24, 2020
@jolheiser jolheiser merged commit b65e954 into go-gitea:master Feb 24, 2020
@jolheiser jolheiser changed the title FIX Pagination of ListAccessTokens and GetIssueWatchers Fix Pagination of ListAccessTokens and GetIssueWatchers Feb 24, 2020
@6543 6543 deleted the fix_api_pagination branch February 24, 2020 23:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants