Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on issues from repository activity page uses absolute url instead of relative. #9570

Closed
2 of 7 tasks
Nhlest opened this issue Dec 31, 2019 · 3 comments
Closed
2 of 7 tasks
Labels

Comments

@Nhlest
Copy link
Contributor

Nhlest commented Dec 31, 2019

  • Gitea version (or commit ref): 1.11.0+dev-530-g9600c2708
  • Git version: 2.24.1
  • Operating system: Debian
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

As you can see from the screenshot, using links on the activity page of gitea redirects me to the full URL using hostname from gitea configs, instead of it being relative using, for example, ip i am accesing gitea at the moment.

Screenshots

Look at the bottom left corner for the tooltip url after me hovering over Test issue link.
screenshot

@Nhlest
Copy link
Contributor Author

Nhlest commented Dec 31, 2019

So i looked around and it seems like every template uses $.RepoLink as a root href url everywhere except for repo/activity.tmpl which uses $.Repository.HTMLURL for some reason, i guess here's an easy fix.

@Nhlest
Copy link
Contributor Author

Nhlest commented Dec 31, 2019

image
After applying changes in the PR above link changes to the correct one (Using local IP in my case)

@lunny lunny added the type/bug label Jan 1, 2020
@lunny
Copy link
Member

lunny commented Jan 1, 2020

Closed by #9571

@lunny lunny closed this as completed Jan 1, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants